Remove keyId from the server keys endpoints
#1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been deprecated forever. Besides, the OpenAPI 3 spec doesn't allow optional path parameters. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
4 tasks
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
turt2live
previously requested changes
Nov 17, 2022
|
What we've done in the past is just copy/pasted the endpoint definition, as annoying as that is. |
I mean, really? Isn't the fact that they are deprecated enough of an indication that if people care about them they need to make a case to undeprecate them? |
|
Not according to our specified deprecation policy: https://spec.matrix.org/v1.5/#deprecation-policy |
|
ugh, what a pain in the ass. I think we should revise that. |
|
it'd only take an MSC 😇 I'm fairly opposed to changing the policy here, but that's a discussion for elsewhere. |
|
I've opened matrix-org/matrix-spec-proposals#3938. |
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
|
I updated the description and changelog entry to mention MSC3938. |
This was referenced Jan 3, 2023
clokep
pushed a commit
to clokep/matrix-spec
that referenced
this pull request
May 3, 2023
* Remove keyId from the server keys endpoints It has been deprecated forever. Besides, the OpenAPI 3 spec doesn't allow optional path parameters. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr> * Add newsfragment Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr> * Fix broken link Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr> * Mention MSC3938 in newfragment Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr> Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec PR for MSC3938.
This is a prerequisite for #1310.
Signed-off-by: Kévin Commaille zecakeh@tedomum.fr
Preview: https://pr1350--matrix-spec-previews.netlify.app