Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add room_types and room_type to /publicRooms #1199

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Aug 3, 2022

@turt2live turt2live marked this pull request as ready for review August 3, 2022 00:26
@turt2live turt2live requested a review from a team as a code owner August 3, 2022 00:26
@turt2live turt2live added this to Needs idea feedback / initial review in Spec Core Team Backlog via automation Aug 3, 2022
@turt2live turt2live moved this from Needs idea feedback / initial review to Requires spec review (post-FCP) in Spec Core Team Backlog Aug 3, 2022
Copy link

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@@ -0,0 +1 @@
Add `room_types` filter and `room_type` response to `/publicRooms`, as per [MSC3827](https://github.com/matrix-org/matrix-spec-proposals/pull/3827).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a newline here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog system doesn't really care, so it depends on whether my editor decided to add it or not :p

@turt2live turt2live merged commit b14759a into main Aug 4, 2022
@turt2live turt2live deleted the travis/filter-spaces branch August 4, 2022 21:15
@turt2live turt2live moved this from Requires spec review (post-FCP) to Done to some definition in Spec Core Team Backlog Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Spec Core Team Backlog
  
Done to some definition
Development

Successfully merging this pull request may close these issues.

None yet

3 participants