Use auth header instead of query param for hs->as comms #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
commented
Aug 3, 2022
| @@ -0,0 +1 @@ | |||
| Replace homeserver authorization approach with an `Authorization` header instead of `access_token` when talking to the application service, as per [MSC2832](https://github.com/matrix-org/matrix-spec-proposals/pull/2832). | |||
There was a problem hiding this comment.
"breaking change" to really highlight that this is different now.
richvdh
reviewed
Aug 4, 2022
Comment on lines
15
to
+19
| homeserverAccessToken: | ||
| type: apiKey | ||
| description: The `hs_token` provided by the application service's registration. | ||
| name: access_token | ||
| in: query | ||
| name: Authorization | ||
| in: header | ||
| description: The `Bearer` `hs_token` provided by the application service's registration. |
There was a problem hiding this comment.
sigh. openapi 3.0 has better support for bearer tokens (https://swagger.io/docs/specification/authentication/bearer-authentication/). It really feels like we need to sort out #331.
There was a problem hiding this comment.
indeed :(
c510b12 was me thinking I could use v3 but reverting to v2
richvdh
approved these changes
Aug 4, 2022
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSC: matrix-org/matrix-spec-proposals#2832
Preview: https://pr1200--matrix-spec-previews.netlify.app