Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use auth header instead of query param for hs->as comms #1200

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Aug 3, 2022

@turt2live turt2live marked this pull request as ready for review August 3, 2022 00:40
@turt2live turt2live requested a review from a team as a code owner August 3, 2022 00:40
@@ -0,0 +1 @@
Replace homeserver authorization approach with an `Authorization` header instead of `access_token` when talking to the application service, as per [MSC2832](https://github.com/matrix-org/matrix-spec-proposals/pull/2832).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"breaking change" to really highlight that this is different now.

Comment on lines 15 to +19
homeserverAccessToken:
type: apiKey
description: The `hs_token` provided by the application service's registration.
name: access_token
in: query
name: Authorization
in: header
description: The `Bearer` `hs_token` provided by the application service's registration.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh. openapi 3.0 has better support for bearer tokens (https://swagger.io/docs/specification/authentication/bearer-authentication/). It really feels like we need to sort out #331.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed :(

c510b12 was me thinking I could use v3 but reverting to v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants