Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth rules wrongly claim that users can demote others of the same power level #699

Closed
turt2live opened this issue Sep 30, 2020 · 1 comment · Fixed by #1269
Closed

Auth rules wrongly claim that users can demote others of the same power level #699

turt2live opened this issue Sep 30, 2020 · 1 comment · Fixed by #1269
Assignees
@richvdh
Labels
A-Room-spec Something to do with the room version specifications

Comments

@turt2live
Copy link
Member

turt2live commented Sep 30, 2020 •
edited
Loading

The auth rules (v1 as a base) only consider a case where the user's power level is higher, but higher is somewhat ambiguous. It should read 'equal to or greater than'.

For reference, here's the current auth rules:
image

When deleting an entry (not changing it), 10d triggers but not 10e.
@turt2live turt2live added A-Room-spec Something to do with the room version specifications spec-bug Something which is in the spec, but is wrong labels Sep 30, 2020
@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 1, 2022
@turt2live turt2live added spec-problem and removed spec-bug Something which is in the spec, but is wrong labels May 28, 2022
@richvdh richvdh self-assigned this Oct 4, 2022
richvdh added a commit that referenced this issue Oct 4, 2022
@richvdh
Clarify auth rules for m.room.power_levels events
7648630 
General clarifications, but in particular: fix some misleading text which
implied you could demote other users with the same PL.

Fixes #699.
@richvdh richvdh mentioned this issue Oct 4, 2022
Merged
@richvdh
Copy link
Member

richvdh commented Oct 4, 2022

Right, yes. One way to fix this would be to extend 10e to cover "For each entry being changed or removed ... other than the sender's own entry", but I find the whole thing hard to follow. #1269 rephrases the whole thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richvdh richvdh

Labels
A-Room-spec Something to do with the room version specifications
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify auth rules for m.room.power_levels events matrix-org/matrix-spec
2 participants
@turt2live @richvdh