Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the deprecated name attribute on HTML anchor elements #1870

Merged
merged 6 commits into from
Jul 10, 2024
Merged

Remove the deprecated name attribute on HTML anchor elements #1870

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b1c3c0d
Remove the deprecated name attribute on HTML anchor elements
Johennes Jun 14, 2024
25da44a
Add changelog
Johennes Jun 14, 2024
162b363
Update content/client-server-api/modules/instant_messaging.md
Johennes Jun 14, 2024
62486a1
Update content/client-server-api/modules/instant_messaging.md
Johennes Jun 14, 2024
4cccccb
Update changelogs/client_server/newsfragments/1870.deprecation
uhoreg Jul 10, 2024
ae8da5e
Rename 1870.deprecation to 1870.removal
uhoreg Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelogs/client_server/newsfragments/1870.deprecation
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if deprecation is the correct classification for this since we're removing it without deprecating it. However, none of the other categories from https://github.com/matrix-org/matrix-spec/blob/main/CONTRIBUTING.rst#adding-to-the-changelog seemed fitting.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a "Removed" section, which isn't listed in the CONTRIBUTING.rst

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. I have opened #1907 to add it to the contribution guide.

Thanks also for adding the MSC to the changelog. I had totally forgotten about that. 🤦‍♂️

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove the deprecated name attribute on HTML anchor elements
uhoreg marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion content/client-server-api/modules/instant_messaging.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ the tag.
| Tag | Permitted Attributes |
|--------|--------------------------------------------------------------------------------------------------------------------------------------------|
| `span` | `data-mx-bg-color`, `data-mx-color`, `data-mx-spoiler` (see [spoiler messages](#spoiler-messages)), `data-mx-maths` (see [mathematical messages](#mathematical-messages)) |
| `a` | `name`, `target`, `href` (provided the value is not relative and has a scheme matching one of: `https`, `http`, `ftp`, `mailto`, `magnet`) |
| `a` | `target`, `href` (provided the value is not relative and has a scheme matching one of: `https`, `http`, `ftp`, `mailto`, `magnet`) |
Johennes marked this conversation as resolved.
Show resolved Hide resolved
| `img` | `width`, `height`, `alt`, `title`, `src` (provided it is a [Matrix Content (`mxc://`) URI](#matrix-content-mxc-uris)) |
| `ol` | `start` |
| `code` | `class` (only classes which start with `language-` for syntax highlighting) |
Expand Down