Clarify that dont_notify and coalesce MUST be gracefully ignored #1890
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
|
I did check the original MSC and that uses (lowercase) "should" and "recommended", but I really think it is a requirement for backwards compatibility. |
Johennes
commented
Jun 25, 2024
| `coalesce` actions. Homeservers MUST ignore these actions by stripping them | ||
| from any actions array they encounter. This means that setting the actions | ||
| on a rule to e.g. `["dont_notify"]` MUST be equivalent to setting an empty | ||
| actions array. |
There was a problem hiding this comment.
Not that I'm keen on making this more complicated but I'm now wondering if this clause should apply to clients as well since they might receive default push rules with dont_notify when connecting to an older server? 🤔
There was a problem hiding this comment.
Yes it probably also applies to clients working with an old server.
There was a problem hiding this comment.
Ok, I have rephrased the paragraph slightly to include clients as well.
clokep
reviewed
Jul 10, 2024
clokep
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: https://github.com/matrix-org/matrix-spec/pull/1501/files#r1176822971.
I replaced the info box with a subsection akin to the one for historical user IDs to prevent using RFC2119 keywords inside an explanatory box.
I also attempted to be a little more verbose about what ignoring means by describing the filtering behavior implemented in Synapse.
CC @clokep
Pull Request Checklist
Preview: https://pr1890--matrix-spec-previews.netlify.app