Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that dont_notify and coalesce MUST be gracefully ignored #1890

Merged
merged 5 commits into from
Jul 10, 2024
+7 −4
Merged

Clarify that dont_notify and coalesce MUST be gracefully ignored #1890

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c616c46
Clarify that dont_notify and coalesce MUST be gracefully ignored
Johennes Jun 25, 2024
6c310ca
Add changelog
Johennes Jun 25, 2024
c7b387c
Extend the logic to clients
Johennes Jun 25, 2024
39e1954
Include clients in changelog entry
Johennes Jun 25, 2024
42e000b
Update changelog.
clokep Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelogs/client_server/newsfragments/1890.clarification
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Clarify that the deprecated dont_notify and coalesce push rule actions MUST be ignored, not rejected by homeservers.
10 changes: 6 additions & 4 deletions content/client-server-api/modules/push.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,11 +184,13 @@ they are represented as a dictionary with a key equal to their name and
other keys as their parameters, e.g.
`{ "set_tweak": "sound", "value": "default" }`.

{{% boxes/note %}}
###### Historical Actions

Older versions of the Matrix specification included the `dont_notify` and
`coalesce` actions. These should both be considered no-ops (ignored, not
rejected) if received from a client.
{{% /boxes/note %}}
`coalesce` actions. Homeservers MUST ignore these actions by stripping them
from any actions array they encounter. This means that setting the actions
on a rule to e.g. `["dont_notify"]` MUST be equivalent to setting an empty
actions array.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I'm keen on making this more complicated but I'm now wondering if this clause should apply to clients as well since they might receive default push rules with dont_notify when connecting to an older server? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it probably also applies to clients working with an old server.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I have rephrased the paragraph slightly to include clients as well.


##### Conditions

Expand Down