Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elections page to a dropdown in the navigationbar #2338

Merged
merged 6 commits into from
Jun 20, 2024

Conversation

MTRNord
Copy link
Collaborator

@MTRNord MTRNord commented May 9, 2024

Fixes #2317

PLEASE make sure that this actually didnt break existing links before merging! I think I got them all but I may have missed one.

Copy link

cloudflare-workers-and-pages bot commented May 9, 2024

Deploying matrix-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: 377590c
Status: ✅  Deploy successful!
Preview URL: https://49465655.matrix-website.pages.dev
Branch Preview URL: https://mtrnord-elections-menu-item.matrix-website.pages.dev

View logs

render = false
+++

* [About](about) – The Matrix.org Foundation About page
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is technically unreachable since its render=false and the about page itself takes this url.

@MTRNord
Copy link
Collaborator Author

MTRNord commented May 9, 2024

image
Bildschirmfoto am 2024-05-09 um 22 27 46

Adds a submenu called "Foundation" (due to the way the hover logic works I had to nest it like this) and it also fix the weird padding situation the submenu was in.

@MTRNord MTRNord force-pushed the MTRNord/elections-menu-item branch from 5079df3 to 6c96e4a Compare May 16, 2024 09:51
@MTRNord MTRNord added the enhancement This would be an improvement to the website. label Jun 5, 2024
@HarHarLinks
Copy link
Contributor

I'm not sure "About Matrix" is the best title for the about page

@thibaultamartin
Copy link
Contributor

I find "About Matrix" to be okay ish, since it talks both about the protocol and the foundation. In the future we might split the content in two distinct pages, but as it is now it works for me.

Do you have ideas that work better?

@HarHarLinks
Copy link
Contributor

HarHarLinks commented Jun 19, 2024

It's okayish, but I don't think it really is about the protocol, and it is in the Foundation dropdown already, I'd keep to the previous simple "about" or go for something that hints more in the direction of project governance

@MTRNord MTRNord merged commit 698f2b1 into main Jun 20, 2024
3 checks passed
@MTRNord MTRNord deleted the MTRNord/elections-menu-item branch June 20, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This would be an improvement to the website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make elections page accessible through the navbar
3 participants