Fix: this.state.chans and channel.users are Map type, not an Object type

[iwalkalone69]

• Object.entries(this.state.chans) is not working as it is a Map, it returns an empty array.
• message.nick in killChannel.users is not working as it is a Map too. Repacing with Map.prototype.has().
• Replacing delete killChannel.users[message.nick] with Map.prototype.delete().
• Doing the same with quitChannel.

[Half-Shot]

Change looks good, but can you:

• Sign off, as per https://github.com/matrix-org/matrix-appservice-bridge/blob/develop/CONTRIBUTING.md#%EF%B8%8F-pull-requests
• Write a changelog summarizing what you've fixed

Optionally, a test would be good to avoid this. We have a nice example in

node-irc/spec/client.spec.ts

Lines 30 to 41 in 96e1cdd

	test('can join a channel and send a message', async () => {
	const { speaker, listener } = server.clients;
	await listener.join('#foobar');
	const messagePromise = listener.waitForEvent('message');
	await speaker.join('#foobar');
	await speaker.say('#foobar', 'Hello world!');
	const [nick, channel, text] = await messagePromise;
	expect(nick).toBe(speaker.nick);
	expect(channel).toBe('#foobar');
	expect(text).toBe('Hello world!');
	});

.

[progval]

So that's why appservice-irc stopped bridging quits months ago! Thanks @iwalkalone69!

[progval]

Did you check onNick doesn't need it too?

[iwalkalone69]

Did you check onNick doesn't need it too?

I didn't check it yet, but probably it will need too. If I can confirm and check it will submit another PR.

[iwalkalone69]

Did you check onNick doesn't need it too?

I have committed another change that fixes this. It uses Map.prototype.forEach() to iterate channels.

[Half-Shot]

Incidentally I think this sort of thing really needs a linting rule, but alas there isn't one yet typescript-eslint/typescript-eslint#6807

[Half-Shot]

Seems like there is a typing fail here?

[iwalkalone69]

Yes, sorry. It is fixed now.

[Half-Shot]

Thanks for the bugfix :)