Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support whois for certfp #110

Merged
merged 6 commits into from
Aug 11, 2023
Merged

Support whois for certfp #110

merged 6 commits into from
Aug 11, 2023

Conversation

Half-Shot
Copy link

@Half-Shot Half-Shot requested a review from a team as a code owner August 10, 2023 16:55
@Half-Shot Half-Shot mentioned this pull request Aug 10, 2023
Open
@progval
Copy link

progval commented Aug 10, 2023

Are you planning to parse the trailing param of rpl_whoiscertfp? be careful with it, it's not meant to be machine-parseable

@Half-Shot
Copy link
Author

Definitely not planning an extraction for this one, looks too unsafe.

AndrewFerr
AndrewFerr approved these changes Aug 11, 2023
View reviewed changes
src/irc.ts Outdated Show resolved Hide resolved
@Half-Shot Half-Shot merged commit c860040 into master Aug 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewFerr AndrewFerr AndrewFerr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Half-Shot @progval @AndrewFerr