Destroy existing socket before allocating a new one #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks fairly safe, thanks for the PR! Are you okay to sign your PR either in the comment above or via commit? Basically follow https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.rst. |
Signed-off-by: Brandon Valentine <brandon@brandonvalentine.com>
bval
force-pushed
the
destroy-socket-before-creating-a-new-one
branch
from
37b6b1a
to
78f0b5d
Compare
|
@Half-Shot No problem! Commit amended w/ signature. Think I got that right. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reconnecting on timeout node-irc will create a new socket without properly destroying the old one. I have observed a race condition as a result of this that can hold multiple connections open at once. I can reliably reproduce this with nandub/hubot-irc. I can end up with as many open sockets as my retry limit.
Documentation for the destroy method can be found here.
I debated various other places to put this, but invoking it in connect() before allocating the connection seems like the safest place for all callers. This code is called from reconnect but could have other callers in the future.