Update to postgres 0.16 and some minor changes #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cargo clippy` suggested to use `is_empty()` instead of `len() > 0`, because this doesn't require to calculate the whole length of the sequence. See: <https://rust-lang.github.io/rust-clippy/master/index.html#len_zero>
`cargo clippy` suggested to use a character instead of a string with a single character. See: <https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern>
To unify the spelling of parameters, i.e. all upper-casse, add the `value_name()` for max_state_group.
Some compressions yield only a few hundred lines saving which isn't worth the database update and the time needed to validate the compression. With the new commandline argument `-m` the output would be suppressed, if not at least the given number of database records would be saved.
|
Needs merge conflicts resolved, it looks like. |
heftig
added a commit
to heftig/rust-synapse-compress-state
that referenced
this pull request
Dec 26, 2019
From Jörg Sommer's PR: matrix-org#10
Merged
heftig
added a commit
to heftig/rust-synapse-compress-state
that referenced
this pull request
Feb 14, 2020
From Jörg Sommer's PR: matrix-org#10
|
Sorry this got ignored for so long! This looks to have been fixed in #15 too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.