Aborts the run of the compressor if it will lead to more rows in the database #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azrenbeth
force-pushed
the
azren/early_abort_negative_compression
branch
from
d32b222
to
5bed248
Compare
Azrenbeth
changed the title
erikjohnston
approved these changes
Aug 24, 2021
Before this, unless min_saved_rows was specified, it would continue to generate the SQL and perform validity.
Co-authored-by: Erik Johnston <erikj@jki.re>
Azrenbeth
force-pushed
the
azren/early_abort_negative_compression
branch
from
c05b04f
to
549a60b
Compare
|
Wouldn't it be better to just default |
That would work, however a fix to #31 would also be needed in that case too. I also did it this way in order to draw extra attention to when the compressor is NOT working as opposed to when it's just not working as well as expected, since that might help fix the creating-extra-rows issue in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUILDS ON azren/all_options_readme_and_help
This aborts the run of the compressor if it will lead to MORE rows in the database
This will prevent accidently running the generated SQL on the database and increasing storage requirements.