Replace printing with logging #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows other packages that use the compressor to control what and how the libary prints.
Azrenbeth
force-pushed
the
azren/replace_printing_with_logging
branch
from
ac9fef2
to
94fca17
Compare
erikjohnston
approved these changes
Sep 27, 2021
src/main.rs
Outdated
| log_builder.init(); | ||
| } else { | ||
| // If COMPRESSOR_LOG_LEVEL was set then use that | ||
| env_logger::Builder::from_env("COMPRESSOR_LOG_LEVEL").init(); |
There was a problem hiding this comment.
As discussed, let's use standard RUST_LOG
Suggested change
| env_logger::Builder::from_env("COMPRESSOR_LOG_LEVEL").init(); | |
| env_logger::init(); |
And RUST_LOG above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #66
The output from the manual tool is unchanged (since the logging is set to have no preamble)
but will allow the autocompressor to ignore some of the output, and format it nicely