Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the 'db' config section to be defined #100

Merged
merged 6 commits into from
May 12, 2020
Merged

Allow the 'db' config section to be defined #100

merged 6 commits into from
May 12, 2020

Conversation

Half-Shot
Copy link
Contributor

Fixes #98

@Half-Shot Half-Shot requested a review from a team April 6, 2020 12:56
richvdh
richvdh previously requested changes Apr 7, 2020
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per #synapse-dev:

can you please get to the bottom of whether it won't start with the old config (in which case #100 won't fix it), or whether it was just a warning (in which case the changelog entry needs fixing)

sygnal/sygnal.py Outdated Show resolved Hide resolved
sygnal/sygnal.py Outdated Show resolved Hide resolved
sygnal/sygnal.py Outdated Show resolved Hide resolved
@anoadragon453 anoadragon453 mentioned this pull request Apr 28, 2020
Closed
@babolivier babolivier mentioned this pull request Apr 29, 2020
Closed
@Half-Shot Half-Shot requested a review from richvdh May 11, 2020 17:13
@babolivier babolivier mentioned this pull request May 12, 2020
Closed
@clokep
Copy link
Member

clokep commented May 12, 2020

This seems to work well in my testing.

@Half-Shot Half-Shot merged commit 98c48f8 into master May 12, 2020
@Half-Shot Half-Shot deleted the hs/fix-db-key branch May 12, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clokep clokep clokep approved these changes

@richvdh richvdh Awaiting requested review from richvdh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config checker doesn't allow for deprecated fields
3 participants
@Half-Shot @clokep @richvdh