Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using poetry #374

Merged
merged 16 commits into from
May 21, 2024
Merged

Switch to using poetry #374

merged 16 commits into from
May 21, 2024

Conversation

devonh
Copy link
Contributor

@devonh devonh commented May 16, 2024

This brings sygnal in line with synapse & allows the use of a poetry.lock file to track dependency versions more precisely.

@devonh devonh requested a review from a team as a code owner May 16, 2024 21:02
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks good, but I think we need to update the dockerfile to use poetry?

@devonh
Copy link
Contributor Author

devonh commented May 17, 2024

Thank you! This looks good, but I think we need to update the dockerfile to use poetry?

Ah! I knew I must be missing something. Will do.

@devonh devonh requested a review from erikjohnston May 17, 2024 20:36
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good. I assume you've manually tested building and running the docker image?

docker/Dockerfile Outdated Show resolved Hide resolved
@devonh devonh merged commit d9560e9 into main May 21, 2024
6 checks passed
@devonh devonh deleted the devon/poetry branch May 21, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants