Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix postgres database configuration breakage #95

Merged
merged 5 commits into from
Apr 2, 2020
Merged

Fix postgres database configuration breakage #95

merged 5 commits into from
Apr 2, 2020

Conversation

Half-Shot
Copy link
Contributor

This fixes:

  • The default sqlite3 configuration from colliding with PostgreSQL
  • Tests not testing ^
  • Postgresql not actually working properly due to '?' '%s' confusion in the query.

@Half-Shot Half-Shot mentioned this pull request Apr 1, 2020
Closed
@Half-Shot Half-Shot requested a review from a team April 1, 2020 19:00
anoadragon453
anoadragon453 requested changes Apr 2, 2020
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nits and a question.

sygnal/gcmpushkin.py Outdated Show resolved Hide resolved
sygnal/gcmpushkin.py Outdated Show resolved Hide resolved
sygnal/sygnal.py Show resolved Hide resolved
@Half-Shot @anoadragon453
Apply suggestions from code review
0e52e98 
Co-Authored-By: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
anoadragon453
anoadragon453 requested changes Apr 2, 2020
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more q

tests/testutils.py Show resolved Hide resolved
sygnal/sygnal.py Show resolved Hide resolved
anoadragon453
anoadragon453 approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Half-Shot Half-Shot merged commit 77713d9 into master Apr 2, 2020
@Half-Shot Half-Shot deleted the hs/fix-db branch April 2, 2020 15:11
@richvdh
Copy link
Member

richvdh commented Apr 2, 2020

shouldn't this have had a changelog file?

@Half-Shot
Copy link
Contributor Author

Yes, I forgot that and included one in the release :|. To pay for my sins, I'll set up a newsfile CI

@richvdh
Copy link
Member

richvdh commented Apr 2, 2020

thanks. If you'd included the newsfile here, we could have pointed out that the word "crash" is misleading...

@Half-Shot
Copy link
Contributor Author

fair point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Half-Shot @richvdh @anoadragon453