Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform troubleshooting documentation and sample configuration details #154

Merged
merged 4 commits into from Oct 7, 2020

Conversation

anoadragon453
Copy link
Member

A customer had an issue where they were using sandbox push tokens with the production server. I don't blame them, as this doesn't seem to have been documented anywhere.

I've added the platform option to the sample config with some explanation, as well as a section in troubleshooting in case others fall down the same path.

While adding to the sample config, I realised that we would eventually end up duplicating nearly every option if we didn't deduplicate early, so that's what I did.

Best reviewed commit-by-commit.

@anoadragon453 anoadragon453 requested a review from a team October 7, 2020 10:51
Copy link
Contributor

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

The sample config is confusing with the multiple layers of comments, but I don't want to ask you to fix that here. 😄

sygnal.yaml.sample Outdated Show resolved Hide resolved
changelog.d/154.doc Outdated Show resolved Hide resolved
sygnal.yaml.sample Outdated Show resolved Hide resolved
@anoadragon453 anoadragon453 merged commit 08318c8 into master Oct 7, 2020
@anoadragon453 anoadragon453 deleted the anoa/sygnal_sample_config_platform branch October 7, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants