Add a docker file #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
previously approved these changes
Sep 24, 2019
ghost
reviewed
Apr 29, 2020
|
@Half-Shot I think this needs a master merged in -- there are conflicts. |
anoadragon453
requested changes
May 12, 2020
There was a problem hiding this comment.
I get a cryptic docker networking error when trying to build the container which I believe is unrelated:
Sending build context to Docker daemon 153.2MB
Step 1/9 : FROM python:3.7-slim as builder
---> d7ee20941226
Step 2/9 : RUN apt-get update && apt-get install -y gcc git libpq-dev
---> Running in 468b9a3c4186
failed to create endpoint boring_ptolemy on network bridge: failed to add the host (vethebbff49) <=> sandbox (vethbe2b839) pair interfaces: operation not supported
So assuming it builds and starts for you, this PR looks good other than the small fixes below.
Bleh Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
anoadragon453
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.