Fix CI and bump actions dependencies to deal with GHA deprecations. #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMRobertson
force-pushed
the
dmr/try-to-fix-ci
branch
from
03f876e
to
04973e5
Compare
|
This seems to work? But the unit tests shouldn't now be passing---the fix only affects the integration test? Extremely suspicious. |
DMRobertson
force-pushed
the
dmr/try-to-fix-ci
branch
from
e322d48
to
54148b9
Compare
DMRobertson
changed the title
Merged
clokep
approved these changes
Oct 25, 2022
| @@ -34,12 +34,14 @@ jobs: | |||
| secret_access_key: my_secret_access_key | |||
| - name: Setup minio | |||
| run: | | |||
| # The version of minio is RELEASE.2022-04-01T03-41-39Z.fips | |||
There was a problem hiding this comment.
Did something change in minio that we're pinning it?
There was a problem hiding this comment.
I haven't dug into this. I tried to pin minio to the version we ought to have been running the last time this test succeeded. It seemed to work. 🤷
There was a problem hiding this comment.
I thought about running a bisection, but being honest I didn't want to faff around with GHA and editing yaml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82.
Drive-by contribution to matrix-org/synapse#14203