Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Deal with Github Actions deprecation warnings #14203

Closed
DMRobertson opened this issue Oct 17, 2022 · 4 comments · Fixed by #15576
Closed

Deal with Github Actions deprecation warnings #14203

DMRobertson opened this issue Oct 17, 2022 · 4 comments · Fixed by #15576
Labels
A-CI Issues related to CI on the Synapse repository A-Testing Issues related to testing in complement, synapse, etc T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Future-Maintenance Things that can't yet be done, but will need cleaning up in a couple of months/releases
Milestone
Revisit: Next Week

Comments

@DMRobertson
Copy link
Contributor

DMRobertson commented Oct 17, 2022 •
edited

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Starting 1st June 2023 workflows using save-state or set-output commands via stdout will fail with an error.

See e.g. https://github.com/matrix-org/synapse/actions/runs/3258600088 (and likely other workflows too)

Node.js 12 actions, save-state and set-output are all "deprecated and will be disabled soon".

PRs:
@DMRobertson DMRobertson added T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. good first issue Good for newcomers labels Oct 17, 2022
@DMRobertson
Copy link
Contributor Author

See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ . No deadline as of yet.

@DMRobertson

This comment was marked as resolved.

Sign in to view
@DMRobertson DMRobertson added A-Testing Issues related to testing in complement, synapse, etc and removed T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. labels Oct 18, 2022
@DMRobertson

This comment was marked as resolved.

Sign in to view
@DMRobertson DMRobertson mentioned this issue Oct 18, 2022
Merged
@DMRobertson DMRobertson self-assigned this Oct 18, 2022
@DMRobertson DMRobertson added T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. and removed good first issue Good for newcomers labels Oct 18, 2022
This was referenced Oct 18, 2022
Merged
Merged
@DMRobertson DMRobertson added the Z-Future-Maintenance Things that can't yet be done, but will need cleaning up in a couple of months/releases label Oct 18, 2022
@DMRobertson DMRobertson added this to the Revisit: Next Year milestone Oct 18, 2022
@erikjohnston
Copy link
Member

There is also the removal of old macos runners that we use to build macos wheels. There are currently brownouts so we should bump this soon, otherwise it breaks building releases.

@DMRobertson DMRobertson mentioned this issue Oct 20, 2022
Merged
@DMRobertson DMRobertson removed their assignment Oct 24, 2022
DMRobertson pushed a commit to matrix-org/synapse-s3-storage-provider that referenced this issue Oct 24, 2022
Bump actions to avoid GHA deprecations
e322d48 
See matrix-org/synapse#14203
DMRobertson pushed a commit to matrix-org/synapse-s3-storage-provider that referenced this issue Oct 24, 2022
Bump actions to avoid GHA deprecations
54148b9 
See matrix-org/synapse#14203
@DMRobertson DMRobertson mentioned this issue Oct 24, 2022
Merged
DMRobertson pushed a commit to matrix-org/backend-meta that referenced this issue Oct 24, 2022
Bump actions to workaround GHA deprecations
1a8479c 
Part of matrix-org/synapse#14203
@DMRobertson DMRobertson mentioned this issue Oct 27, 2022
Merged
DMRobertson pushed a commit that referenced this issue Nov 2, 2022
Use maintained action to install Rust
ad2f13a 
Part of #14203. Like the changes in #14313.
@DMRobertson DMRobertson mentioned this issue Nov 2, 2022
Merged
DMRobertson pushed a commit that referenced this issue Nov 2, 2022
Use maintained action to install Rust in latest deps/twisted trunk jo…
e5cd278 
…bs (#14351)

* Use maintained action to install Rust

Part of #14203. Like the changes in #14313.

* Changelog
@turt2live turt2live mentioned this issue Nov 22, 2022
Open
@DMRobertson DMRobertson mentioned this issue Dec 2, 2022
Merged
DMRobertson pushed a commit to matrix-org/sliding-sync that referenced this issue Mar 21, 2023
Deal with upcoming GHA deprecations
47d239e 
See
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I've done similar in matrix-org/synapse#14203
@DMRobertson DMRobertson mentioned this issue Mar 21, 2023
Merged
DMRobertson pushed a commit to matrix-org/sytest that referenced this issue Apr 4, 2023
Bump docker actions to latest stable release
a8978ca 
Part of matrix-org/synapse#14203

I've checked changelogs and AFAICS these are backwards compatible for
our purposes. (There's a semver bump because a newer version of GHA
runners and/or node.js is required. But we don't care about those.)
@DMRobertson DMRobertson mentioned this issue Apr 4, 2023
Merged
DMRobertson pushed a commit to matrix-org/synapse-s3-storage-provider that referenced this issue Apr 4, 2023
Deal with GHA deprecation warnings
10fa9d6 
Part of matrix-org/synapse#14203
@DMRobertson DMRobertson mentioned this issue Apr 4, 2023
Merged
DMRobertson pushed a commit to matrix-org/synapse-s3-storage-provider that referenced this issue Apr 4, 2023
Deal with GHA deprecation warnings (#95)
1beb6af 
Part of matrix-org/synapse#14203
DMRobertson pushed a commit to matrix-org/sytest that referenced this issue Apr 4, 2023
Bump docker actions to latest stable release (#1347)
16e026b 
Part of matrix-org/synapse#14203

I've checked changelogs and AFAICS these are backwards compatible for
our purposes. (There's a semver bump because a newer version of GHA
runners and/or node.js is required. But we don't care about those.)
DMRobertson pushed a commit to matrix-org/complement that referenced this issue Apr 6, 2023
Bump checkout action
176320a 
Drive-by fix for matrix-org/synapse#14203
DMRobertson pushed a commit to matrix-org/complement that referenced this issue Apr 6, 2023
Bump checkout action
35a1a16 
Drive-by fix for matrix-org/synapse#14203
DMRobertson pushed a commit to matrix-org/complement that referenced this issue Apr 6, 2023
Fix CI by ensuring gotestfmt is on PATH, plus cleanups (#634)
bcc2bce 
* Use setup-go action

This was my first attempt to fix CI. Go 1.17 is no longer available on
runners (actions/runner-images#7276 maybe)
and I wondered if that might help with that.

Unfortunately I think not. But we should get some go build caching as a
side effect of using this action.

* Bump checkout action

Drive-by fix for matrix-org/synapse#14203

* Check that gotestfmt is installed

no `-version` flag, so `help` will have to do

* `go install gotestfmt` instead of `go get`

IDK why this suddenly started failing, but `go install` seems to put it
on the PATH in a way that makes CI work.
DMRobertson pushed a commit to matrix-org/sygnal that referenced this issue Apr 21, 2023
Bump GHA actions
775bb3e 
part of matrix-org/synapse#14203
DMRobertson pushed a commit to matrix-org/sygnal that referenced this issue Apr 21, 2023
Bump GHA actions
06f41d0 
part of matrix-org/synapse#14203
DMRobertson pushed a commit to matrix-org/sygnal that referenced this issue Apr 21, 2023
Bump GHA actions
7248484 
part of matrix-org/synapse#14203
DMRobertson pushed a commit to matrix-org/sygnal that referenced this issue Apr 21, 2023
Bump GHA actions
3d7007a 
part of matrix-org/synapse#14203
DMRobertson pushed a commit to matrix-org/sygnal that referenced this issue Apr 21, 2023
Bump GHA actions
e8a8237 
part of matrix-org/synapse#14203
DMRobertson pushed a commit to matrix-org/sygnal that referenced this issue Apr 21, 2023
Bump GHA actions
fd470c0 
part of matrix-org/synapse#14203
DMRobertson pushed a commit to matrix-org/sygnal that referenced this issue Apr 21, 2023
Bump GHA actions
b2201c2 
part of matrix-org/synapse#14203
DMRobertson pushed a commit to matrix-org/sygnal that referenced this issue Apr 21, 2023
Bump GHA actions
d24efe1 
part of matrix-org/synapse#14203
DMRobertson pushed a commit to matrix-org/sygnal that referenced this issue Apr 21, 2023
@clokep
Modernise tooling and fix CI failing (#335)
4e1ed66 
* Move from setup.py to pyproject.toml

Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>

* Ensure unit tests run

IDK we sometimes have to invoke trial explicitly like this

* Use ruff instead of flake8

And remove py2-style type annotations, which ruff doesn't recognise

Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>

* Bump GHA actions

part of matrix-org/synapse#14203

* Run black

Presumably this fixes complaints from #333 and #334

* Move isort config to pyproject

* Also lint stubs

* Bump GHA actions

part of matrix-org/synapse#14203

* Fix an unintended rename in #333

Needed for unit tests to be happy

* Changelog

---------

Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
@MadLittleMods MadLittleMods added the A-CI Issues related to CI on the Synapse repository label Apr 25, 2023
This was referenced May 11, 2023
Closed
Merged
@DMRobertson DMRobertson mentioned this issue Jun 6, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-CI Issues related to CI on the Synapse repository A-Testing Issues related to testing in complement, synapse, etc T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Future-Maintenance Things that can't yet be done, but will need cleaning up in a couple of months/releases
Projects
None yet
Milestone
Revisit: Next Week
Development

Successfully merging a pull request may close this issue.

Deal with more GHA deprecations matrix-org/synapse
3 participants
@MadLittleMods @erikjohnston @DMRobertson