Use correct type for what start_as_current_span returns

See: - open-telemetry/opentelemetry-python#198 (comment) - open-telemetry/opentelemetry-python#219
matrix-org · Jul 30, 2022 · 070195a · 070195a
1 parent d848156
commit 070195a
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/synapse/logging/tracing.py b/synapse/logging/tracing.py
@@ -173,6 +173,7 @@ def set_fates(clotho, lachesis, atropos, father="Zues", mother="Themis"):
     TYPE_CHECKING,
     Any,
     Callable,
+    ContextManager,
     Dict,
     Generator,
     Iterable,
@@ -476,7 +477,7 @@ def start_active_span(
     end_on_exit: bool = True,
     # For testing only
     tracer: Optional["opentelemetry.sdk.trace.TracerProvider"] = None,
-) -> Iterator["opentelemetry.trace.span.Span"]:
+) -> ContextManager["opentelemetry.trace.span.Span"]:
     if opentelemetry is None:
         return contextlib.nullcontext()  # type: ignore[unreachable]