Fix formatting string when oEmbed errors occur. (#11061)

matrix-org · Oct 12, 2021 · 1db9282 · 1db9282
1 parent 333d6f4
commit 1db9282
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelog.d/11061.bugfix b/changelog.d/11061.bugfix
@@ -0,0 +1 @@
+Fix a bug introduced in Synapse v1.44.0 when logging errors during oEmbed processing.
diff --git a/synapse/rest/media/v1/oembed.py b/synapse/rest/media/v1/oembed.py
@@ -191,7 +191,7 @@ def parse_oembed_response(self, url: str, raw_body: bytes) -> OEmbedResult:
 
         except Exception as e:
             # Trap any exception and let the code follow as usual.
-            logger.warning(f"Error parsing oEmbed metadata from {url}: {e:r}")
+            logger.warning("Error parsing oEmbed metadata from %s: %r", url, e)
             open_graph_response = {}
             cache_age = None