Don't use keyword arguments when initialising modules (#13060)

matrix-org · Jun 15, 2022 · 417f4cf · 417f4cf
1 parent 75fb10e
commit 417f4cf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelog.d/13060.misc b/changelog.d/13060.misc
@@ -0,0 +1 @@
+Don't instantiate modules with keyword arguments.
diff --git a/synapse/app/_base.py b/synapse/app/_base.py
@@ -450,7 +450,7 @@ def run_sighup(*args: Any, **kwargs: Any) -> None:
     # before we start the listeners.
     module_api = hs.get_module_api()
     for module, config in hs.config.modules.loaded_modules:
-        m = module(config=config, api=module_api)
+        m = module(config, module_api)
         logger.info("Loaded module %s", m)
 
     load_legacy_spam_checkers(hs)