Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Properly update retry_last_ts when hitting the maximum retry interval
Browse files Browse the repository at this point in the history
This was broken in 1.90 when the maximum retry interval got changed from
almost infinite to a week (and made configurable).

fixes #16101

Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
  • Loading branch information
deepbluev7 committed Aug 22, 2023
1 parent 6d7c63f commit 440ff03
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion synapse/storage/databases/main/transactions.py
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ def _set_destination_retry_timings_txn(
WHERE
EXCLUDED.retry_interval = 0
OR destinations.retry_interval IS NULL
OR destinations.retry_interval < EXCLUDED.retry_interval
OR destinations.retry_interval <= EXCLUDED.retry_interval
"""

txn.execute(sql, (destination, failure_ts, retry_last_ts, retry_interval))
Expand Down

0 comments on commit 440ff03

Please sign in to comment.