Merge pull request #9361 from matrix-org/babolivier/third_party_valid…

…ation Remove unneeded type constraints on 3rd party protocol lookup responses
matrix-org · Feb 9, 2021 · fb0e14e · fb0e14e
2 parents 5f716fa + 29ae04a
commit fb0e14e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/changelog.d/9361.bugfix b/changelog.d/9361.bugfix
@@ -0,0 +1 @@
+Fix a bug causing Synapse to impose the wrong type constraints on fields when processing responses from appservices to `/_matrix/app/v1/thirdparty/user/{protocol}`.
diff --git a/synapse/appservice/api.py b/synapse/appservice/api.py
@@ -76,9 +76,6 @@ def _is_valid_3pe_result(r, field):
     fields = r["fields"]
     if not isinstance(fields, dict):
         return False
-    for k in fields.keys():
-        if not isinstance(fields[k], str):
-            return False
 
     return True