Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

followup on asynchronous-federation work #10275

Closed
9 tasks done
richvdh opened this issue Jun 29, 2021 · 5 comments
Closed
9 tasks done

followup on asynchronous-federation work #10275

richvdh opened this issue Jun 29, 2021 · 5 comments
Labels
P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@richvdh
Copy link
Member

richvdh commented Jun 29, 2021

A few things it might be good to think about having landed #10272:

@erikjohnston
Copy link
Member

matrix-org/sytest#1059 fixes one of the tests.

@clokep
Copy link
Contributor

clokep commented Jun 30, 2021

This also seems to be causing a complement test to fail: TestOutboundFederationIgnoresMissingEventWithBadJSONForRoomVersion6

@ShadowJonathan

This comment has been minimized.

@clokep
Copy link
Contributor

clokep commented Jun 30, 2021

matrix-org/complement#142 updates complement to match the sytest blacklist applied in #10272.

@erikjohnston
Copy link
Member

Some more monitoring has been added at #10284 and #10279

@callahad callahad added P1 P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches and removed P1 labels Jul 1, 2021
richvdh added a commit to matrix-org/complement that referenced this issue Jul 8, 2021
…r room version 6'

We can't assume that homeservers will process inbound federation events synchronously.

In this particular case we replace the check for errors in /send response with a check that if we send a new event that references the expected rejected event we'll see a request for that event come in.

c.f. matrix-org/synapse#10275
richvdh added a commit to matrix-org/complement that referenced this issue Jul 9, 2021
…r room version 6' (#152)

This test got blacklisted for the release of Synapse 1.37.1.

We can't assume that homeservers will process inbound federation events synchronously.

In this particular case we replace the check for errors in /send response with a check that if we send a new event that references the expected rejected event we'll see a request for that event come in.

c.f. matrix-org/synapse#10275 and matrix-org/sytest#1061
@erikjohnston erikjohnston added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Jul 23, 2021
@erikjohnston erikjohnston removed their assignment Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

No branches or pull requests

5 participants