Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Dedicated admin API for blocking a room #11283

Closed
DMRobertson opened this issue Nov 9, 2021 · 2 comments · Fixed by #11324
Closed

Dedicated admin API for blocking a room #11283

DMRobertson opened this issue Nov 9, 2021 · 2 comments · Fixed by #11324
Labels
A-Admin-API P4 (OBSOLETE: use S- labels.) Okay backlog: will not schedule, will accept patches T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@DMRobertson
Copy link
Contributor

#11228 was confusing to understand, because the API call to shutdown room does several different things at once. In that change I ended up introducing a bodge, allowing admins to use that endpoint to block a room that doesn't exist.

I think there is a case for an admin API call that blocks this room and nothing else. (See also #2392).

@DMRobertson DMRobertson added A-Admin-API T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. P4 (OBSOLETE: use S- labels.) Okay backlog: will not schedule, will accept patches labels Nov 9, 2021
@dklimpel
Copy link
Contributor

dklimpel commented Nov 9, 2021

IMO unblocking a room would be helpful, too.
Something like:

POST /_synapse/admin/v1/rooms/<room_id>/block
{
    "block": true
}

And perhaps a list of blocked rooms:
GET /_synapse/admin/v1/rooms/blocked

@DMRobertson
Copy link
Contributor Author

Closed via #11324 .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Admin-API P4 (OBSOLETE: use S- labels.) Okay backlog: will not schedule, will accept patches T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants