Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When we redact events, any mxc content they refer to should be redacted too (SYN-216) #1263

Open
matrixbot opened this issue Dec 24, 2014 · 12 comments

Comments

@matrixbot
Copy link
Member

commented Dec 24, 2014

It's a bit of a disasterous thinko that we can redact events which point to stuff in the media repo, and that content is subsequently preserved even though the event is nuked. We should rm it and its caches too (assuming the HS is honouring redactions).

(Imported from https://matrix.org/jira/browse/SYN-216)

(Reported by @ara4n)

@matrixbot

This comment has been minimized.

Copy link
Member Author

commented Dec 24, 2014

Jira watchers: @ara4n

@matrixbot

This comment has been minimized.

Copy link
Member Author

commented Dec 24, 2014

Links exported from Jira:

relates to SYN-576

@matrixbot matrixbot changed the title When we redact events, any mxc content they refer to should be redacted too (SYN-216) When we redact events, any mxc content they refer to should be redacted too (https://github.com/matrix-org/synapse/issues/1263) Nov 7, 2016
@matrixbot matrixbot changed the title When we redact events, any mxc content they refer to should be redacted too (https://github.com/matrix-org/synapse/issues/1263) When we redact events, any mxc content they refer to should be redacted too (SYN-216) Nov 7, 2016
@ara4n ara4n added p1 and removed p2 labels Jan 6, 2017
@ara4n

This comment has been minimized.

Copy link
Member

commented Jan 6, 2017

We just had a minor disaster with this happening (the MXC URL was bridged to IRC, so redacting the content on Matrix was achieving nothing). This should be trivial to fix...

@erikjohnston

This comment has been minimized.

Copy link
Member

commented Jan 6, 2017

@ara4n

This comment has been minimized.

Copy link
Member

commented Jan 8, 2017

I wonder whether a good enough compromise would be for HSes purge redacted data after a few days (Windows Recycle Bin stylee), albeit with the option of configuring the retention per HS. The idea that sensitive data can be left visible to HS admins (and clogging up diskspace) indefinitely, after being redacted, feels undesirable and unintuitive.

@jfrederickson

This comment has been minimized.

Copy link

commented Apr 29, 2017

This came up in #matrix:matrix.org earlier today - as an HS admin, I would really really like to be able to configure my HS to purge redacted content. At the very least, I don't want my HS to continue to serve requests for it from the media repo.

Specifically in reference to illicit content, continuing to serve it from my HS could put me in a really tough spot, legally. And if it's redacted and therefore not easy to find in the first place...

@uhoreg

This comment has been minimized.

Copy link
Member

commented Nov 3, 2017

Of course, you have to be careful that the mxc content isn't referred to by a different event (possibly including an encrypted event).

@rkfg

This comment has been minimized.

Copy link
Contributor

commented Dec 12, 2017

This is absolutely needed to keep the homeserver storage relatively small. I set it up on a VPS and it's growing constantly. It'll become a problem in several months. At the same time we should preserve some content and maybe events from deletion like avatars of users and rooms. It would not be nice to suddenly lose them after a maintenance cycle.

@Mikaela

This comment has been minimized.

Copy link

commented Dec 19, 2018

Related: #1287.

Is #2369 a duplicate of this one?

@anoadragon453

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

One tricky point is that we can't just have the server delete the media on event redaction as in encrypted rooms it does not know what the attached mxc:// url is.

@ara4n

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

the redacting client can do it though.

@richvdh

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

the redacting client can do it though.

Only if we propose a way to delete media across federation (matrix-org/matrix-doc#790)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
You can’t perform that action at this time.