-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Conversation
Closes #13938. |
@erikjohnston would you mind taking a look? I think this is sane and I think we're happy to publish arm wheels? Wanted to check though since you mentioned all the extra wheels being painful during the release process. |
Run in progress at https://github.com/matrix-org/synapse/actions/runs/3268733324 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think this is sane, except for building aarch64 wheels on PRs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge thanks for working through this. Are you able to work through the comments we've raised?
Yes will do. Do you prefer commits squashed/amended or separated? |
Many thanks. Ideally separated on the PR: they'll get squash-merged at the end. |
Signed-off-by: MichaIng <micha@dietpi.com>
Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
Signed-off-by: MichaIng <micha@dietpi.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than making this not build ARM wheels on PRs I think this is great---thanks again for working through the details.
Signed-off-by: MichaIng <micha@dietpi.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for picking this up when I dropped it!
Pull Request Checklist
EventStore
toEventWorkerStore
.".code blocks
.(run the linters)