Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add aarch64 wheels to CI #14212

Merged
merged 4 commits into from
Oct 18, 2022
Merged

Add aarch64 wheels to CI #14212

merged 4 commits into from
Oct 18, 2022

Conversation

MichaIng
Copy link
Contributor

@MichaIng MichaIng commented Oct 17, 2022

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

@DMRobertson
Copy link
Contributor

Closes #13938.

@DMRobertson
Copy link
Contributor

@erikjohnston would you mind taking a look? I think this is sane and I think we're happy to publish arm wheels? Wanted to check though since you mentioned all the extra wheels being painful during the release process.

@DMRobertson
Copy link
Contributor

Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think this is sane, except for building aarch64 wheels on PRs

@clokep clokep linked an issue Oct 18, 2022 that may be closed by this pull request
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge thanks for working through this. Are you able to work through the comments we've raised?

changelog.d/14212.feature Outdated Show resolved Hide resolved
.github/workflows/release-artifacts.yml Show resolved Hide resolved
.github/workflows/release-artifacts.yml Show resolved Hide resolved
@MichaIng
Copy link
Contributor Author

MichaIng commented Oct 18, 2022

Are you able to work through the comments we've raised?

Yes will do. Do you prefer commits squashed/amended or separated?

@DMRobertson
Copy link
Contributor

Are you able to work through the comments we've raised?

Yes will do. Do you prefer commits squashed or separated?

Many thanks. Ideally separated on the PR: they'll get squash-merged at the end.

MichaIng and others added 3 commits October 18, 2022 15:28
Signed-off-by: MichaIng <micha@dietpi.com>
Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
Signed-off-by: MichaIng <micha@dietpi.com>
@DMRobertson DMRobertson self-requested a review October 18, 2022 13:38
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than making this not build ARM wheels on PRs I think this is great---thanks again for working through the details.

Signed-off-by: MichaIng <micha@dietpi.com>
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for picking this up when I dropped it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add aarch64 wheels to build workflow
4 participants