Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Email notification template used for matrix.org HS regressed #14421

Closed
jryans opened this issue Nov 12, 2022 · 4 comments · Fixed by #14448
Closed

Email notification template used for matrix.org HS regressed #14421

jryans opened this issue Nov 12, 2022 · 4 comments · Fixed by #14448
Assignees
@erikjohnston
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@jryans
Copy link
Contributor

jryans commented Nov 12, 2022

Description

Sometime between 2022-10-31 and 2022-11-04, the matrix.org HS email notification template seemed to regress somehow (at least for my @jryans:matrix.org account).

Here are two example emails in each style for comparison:

2022-10-31

image

2022-11-04

image

I assume the 2022-10-31 style is still the intended one, as it has much nicer visual styling. Perhaps some configuration somewhere needs to be fixed...?

Steps to reproduce

  • Have an account on matrix.org
  • Enable email notifications
  • Cause an email to be sent

Homeserver

matrix.org

Synapse Version

1.71.0rc2 (b=matrix-org-hotfixes,39ea774cff,dirty)

Installation Method

No response

Platform

N/A

Relevant log output

N/A

Anything else that would be useful to know?

No response
@DMRobertson
Copy link
Contributor

Probably #13652?

@jryans
Copy link
Contributor Author

jryans commented Nov 14, 2022

After inspecting the HTML for a bit, it seems like the newer mails are missing the doctype, head, body, etc. elements.

Perhaps it's because notif_mail.html is missing the {% extends "_base.html" %} line that most others have...?

@clokep
Copy link
Contributor

clokep commented Nov 14, 2022

Perhaps it's because notif_mail.html is missing the {% extends "_base.html" %} line that most others have...?

Sounds like this got missed in the refactoring, yes. Thanks for spotting. 👍

@erikjohnston erikjohnston added S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. O-Occasional Affects or can be seen by some users regularly or most users rarely labels Nov 15, 2022
erikjohnston added a commit that referenced this issue Nov 15, 2022
@erikjohnston
Fix HTML templates missing correct HTML tags
d14035f 
Fixes #14421.

Broke in #13652.
@erikjohnston erikjohnston mentioned this issue Nov 15, 2022
Merged
@bmarty
Copy link

bmarty commented Nov 16, 2022

OOI in the notice I can see some weird things:

image

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@erikjohnston erikjohnston

Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix HTML templates missing correct HTML tags matrix-org/synapse
5 participants
@jryans @clokep @bmarty @erikjohnston @DMRobertson