Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

CI fails to test Python 3.11 wheel on Ubuntu 20.04 #15109

Closed
DMRobertson opened this issue Feb 20, 2023 · 2 comments · Fixed by #15114
Closed

CI fails to test Python 3.11 wheel on Ubuntu 20.04 #15109

DMRobertson opened this issue Feb 20, 2023 · 2 comments · Fixed by #15114
Labels
A-Packaging Our Debian packages, docker images; or issues relevant to downstream packagers T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Release-Blocker Must be resolved before making a release

Comments

@DMRobertson
Copy link
Contributor

frozendict is failing to install all of a sudden.
https://github.com/matrix-org/synapse/actions/runs/4221352086/jobs/7328543146#step:8:2301

It looks like it is failing to invoke gcc somehow: https://github.com/matrix-org/synapse/actions/runs/4221352086/jobs/7328543146#step:8:2418

The frozendict maintainer made a release over the weekend: https://github.com/Marco-Sulla/python-frozendict/releases/tag/v2.3.5

They note:

C Extension is now optional by default
Pure py package will be no more pubished on Pypi

There is no C-extension for 3.11 (Marco-Sulla/python-frozendict#68, Marco-Sulla/python-frozendict#67 (comment))... so how are you be expected to install the pure-python version on Python 3.11?
@DMRobertson DMRobertson added A-Packaging Our Debian packages, docker images; or issues relevant to downstream packagers T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Release-Blocker Must be resolved before making a release labels Feb 20, 2023
@DMRobertson
Copy link
Contributor Author

Oh, I think I see the problem. frozendict's setup.py requires you to build the C extension if it is running under cibuildwheel: https://github.com/Marco-Sulla/python-frozendict/blob/master/setup.py#L187-L192

@DMRobertson
Copy link
Contributor Author

We could probably hack around this by suppressing the env var in the test step or something... but that combined with the confusing release is the straw that broke the camel's back. @reivilibre suggests switching out for https://github.com/corenting/immutabledict which seems much more sane and avoids all of the horrible C extension nightmare.

DMRobertson pushed a commit that referenced this issue Feb 20, 2023
Upper-bound frozendict dependency
8375fd2 
This is an ugly kludge to solve
#15109. It is not the most
friendly thing to do for downstream packagers (apologies), but we are a)
running low on time at the moment, and b) seeking to remove frozendict
anyway.
@DMRobertson DMRobertson mentioned this issue Feb 20, 2023
Merged
DMRobertson pushed a commit that referenced this issue Feb 21, 2023
Upper-bound frozendict dependency (#15114)
8cede52 
* Upper-bound frozendict dependency

This is an ugly kludge to solve
#15109. It is not the most
friendly thing to do for downstream packagers (apologies), but we are a)
running low on time at the moment, and b) seeking to remove frozendict
anyway.

* Changelog
@DMRobertson DMRobertson mentioned this issue Feb 27, 2023
Closed
@DMRobertson DMRobertson mentioned this issue Mar 14, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Packaging Our Debian packages, docker images; or issues relevant to downstream packagers T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Release-Blocker Must be resolved before making a release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upper-bound frozendict dependency matrix-org/synapse
1 participant
@DMRobertson