Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Clean-up event_txn_id table #16042

Closed
clokep opened this issue Aug 1, 2023 · 2 comments · Fixed by #16268 or #16522
Closed

Clean-up event_txn_id table #16042

clokep opened this issue Aug 1, 2023 · 2 comments · Fixed by #16268 or #16522
Assignees
@clokep
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@clokep
Copy link
Contributor

clokep commented Aug 1, 2023

  1. In a future version we need to stop reading & writing to the event_txn_id table & bump the schema version.
  2. In a future future version, bump the minimum schema version to the new version in step 1 & drop the event_txn_id table.
  3. In step 2, we can also stop writing the access token ID into the internal metadata for events.

See #15629 (comment)
@clokep clokep added S-Minor Blocks non-critical functionality, workarounds exist. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Aug 1, 2023
@clokep clokep added this to the Revisit: Next Month milestone Aug 1, 2023
@clokep clokep self-assigned this Aug 1, 2023
@clokep clokep mentioned this issue Aug 1, 2023
Merged
@clokep clokep mentioned this issue Aug 23, 2023
Merged
@clokep
Copy link
Contributor Author

clokep commented Sep 6, 2023

The first part of this landed in v1.92.0rc1.

@clokep clokep mentioned this issue Sep 6, 2023
Merged
@clokep
Copy link
Contributor Author

clokep commented Oct 18, 2023

See #16465

@clokep clokep reopened this Oct 18, 2023
This was referenced Oct 18, 2023
Merged
Merged
@wrjlewis wrjlewis removed this from the Revisit: Next Month milestone Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@clokep clokep

Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
2 participants
@clokep @wrjlewis