Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix user directory test for deactivated support user. #16157

Merged
merged 3 commits into from Aug 22, 2023
Merged

Fix user directory test for deactivated support user. #16157

merged 3 commits into from Aug 22, 2023

Conversation

clokep
Copy link
Contributor

@clokep clokep commented Aug 22, 2023

Per @DMRobertson's explanation:

I think the invariant that the test should be asserting is:

  • after deactivating the support user, it should not be visible in the user directory

@clokep clokep mentioned this pull request Aug 22, 2023
Merged
4 tasks
DMRobertson
DMRobertson approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems sane (and simpler than messing about with mocks to see if they get called)

@clokep clokep marked this pull request as ready for review August 22, 2023 12:31
@clokep clokep requested a review from a team as a code owner August 22, 2023 12:31
@clokep clokep removed the request for review from a team August 22, 2023 12:31
@clokep clokep enabled auto-merge (squash) August 22, 2023 12:41
@clokep clokep disabled auto-merge August 22, 2023 13:07
@clokep clokep merged commit b657e89 into develop Aug 22, 2023
35 of 37 checks passed
@clokep clokep deleted the clokep/update-user-dir-test branch August 22, 2023 13:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DMRobertson DMRobertson DMRobertson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clokep @DMRobertson