Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove useless async job to delete device messages on sync #16491

Merged

Conversation

MatMaul
Copy link
Contributor

@MatMaul MatMaul commented Oct 14, 2023

We only deliver up to 100 device messages per sync, so use of an async job to delete those is not needed.
cf #16479.

Signed-off-by: Mathieu Velten matmaul@gmail.com

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

@MatMaul MatMaul force-pushed the improve-sync-delete-device-msgs branch from 86f89ac to 90348c0 Compare October 14, 2023 19:20
@MatMaul MatMaul changed the base branch from improve-sync-delete-device-msgs to develop October 14, 2023 19:57
@MatMaul MatMaul marked this pull request as ready for review October 14, 2023 22:22
@MatMaul MatMaul requested a review from a team as a code owner October 14, 2023 22:22
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci!

@erikjohnston erikjohnston merged commit eee6474 into matrix-org:develop Oct 16, 2023
38 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants