Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove useless async job to delete device messages on sync #16484

Closed
wants to merge 1 commit into from

Conversation

MatMaul
Copy link
Contributor

@MatMaul MatMaul commented Oct 13, 2023

We only deliver up to 100 device messages per sync, so use of an async job to delete those is not needed.
cf #16479.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

@MatMaul MatMaul force-pushed the improve-sync-delete-device-msgs branch 4 times, most recently from 7054e39 to 9571b7d Compare October 13, 2023 13:40
@MatMaul MatMaul force-pushed the improve-sync-delete-device-msgs branch from 9571b7d to b2559e1 Compare October 13, 2023 14:16
@MatMaul MatMaul marked this pull request as ready for review October 13, 2023 15:31
@MatMaul MatMaul requested a review from a team as a code owner October 13, 2023 15:31
@MatMaul MatMaul closed this Oct 14, 2023
@clokep
Copy link
Contributor

clokep commented Oct 14, 2023

Replaced by #16491.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants