Add support for specifying multiple bind addresses #1709
Conversation
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
| # The empty string will cause synapse to listen on all interfaces. | ||
| bind_address: '' | ||
| # Local addresses to listen on. | ||
| # This will listen on all IPv4 addresses by default. |
There was a problem hiding this comment.
Can we have the example in here of how to listen on ipv6 too, even if commented out? presumably
# - '::' # to listen on all IPv6 interfaces
There was a problem hiding this comment.
I was thinking about that, but also need to specify that having both uncommented at the same time won't work on Linux, so I was thinking about whether to document this in the default config or somewhere else?
There was a problem hiding this comment.
it's going to be such a common scenario (plus we want to advertise that ipv6 is here, yay!) that i suspect it's worth spelling it out (assuming you are sure that the second bind will fail?)
how about:
# uncomment to listen on all IPv6 interfaces
# N.B. on Linux this also listens on IPv4, so you'll need to comment out the line above.
# - '::'
There was a problem hiding this comment.
On Linux you'll get an errno 98, yeah, annoyingly.
Comment added below.
|
this LGTM, modulo the minor doc change. annoying that the binding setup is copypasted over all the different workers though, but not your fault... |
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
|
ok to test |
|
lgtm - going to merge and see what happens! thanks @kyrias! |
No description provided.