This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
use bcrypt.checkpw #2949
Merged
use bcrypt.checkpw #2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
in bcrypt 3.1.0 checkpw got introduced (already 2 years ago) This makes use of that with enhancements which might get introduced by that Signed-Off-by: Matthias Kesler <krombel@krombel.de>
krombel
force-pushed
the
use_bcrypt_checkpw
branch
from
e611100
to
ed9b5ec
Compare
|
this is the opposite to #619, but it's true that bcrypt reintroduced Given that debian stable has 3.1.2, I can't see much argument against this. |
|
@matrixbot: ok to test |
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in bcrypt 3.1.0
checkpwgot introduced (nearly 2 years ago)This makes use of that with enhancements which might get introduced
by that.
The concrete PR for that feature is pyca/bcrypt#76
Signed-Off-by: Matthias Kesler krombel@krombel.de