Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

register_new_matrix_user talks to https://localhost:8448, whether or not the C-S API is configured there #3672

Closed
richvdh opened this issue Aug 9, 2018 · 2 comments · Fixed by #13616
Closed

register_new_matrix_user talks to https://localhost:8448, whether or not the C-S API is configured there #3672

richvdh opened this issue Aug 9, 2018 · 2 comments · Fixed by #13616
Assignees
@richvdh
Labels
z-minor (Deprecated Label) z-p2 (Deprecated Label)

Comments

@richvdh
Copy link
Member

richvdh commented Aug 9, 2018

for anyone running with the recommended config of having the C-S API behind a reverse-proxy, or moving things to non-standard ports, this isn't going to work. Given we parse the config file to find the shared secret, why don't we also at least sanity-check that we're connecting to a port with the C-S API exposed?
@neilisfragile neilisfragile added z-p2 (Deprecated Label) z-minor (Deprecated Label) labels Aug 28, 2018
This was referenced Jul 4, 2019
Closed
Open
@richvdh
Copy link
Member Author

richvdh commented Jan 27, 2020

also: wouldn't http://localhost:8008 be a more sensible default, since that is where synapse listens with the default configuration?

@richvdh richvdh mentioned this issue Jan 27, 2020
Closed
@clokep clokep mentioned this issue Apr 9, 2020
Closed
@melroy89
Copy link

melroy89 commented Oct 4, 2020

Yes, so the command on Docker would be:

docker exec -it synapse register_new_matrix_user http://localhost:8008 -c /data/homeserver.yaml

@richvdh richvdh mentioned this issue Feb 8, 2021
Closed
@erikjohnston erikjohnston mentioned this issue Feb 8, 2021
Open
richvdh added a commit that referenced this issue Aug 24, 2022
@richvdh
register_new_matrix_user: read server url from config
d8114e0 
Fixes #3672:
`https://localhost:8448` is virtually never right.
@richvdh richvdh mentioned this issue Aug 24, 2022
Merged
richvdh added a commit that referenced this issue Aug 24, 2022
@richvdh
register_new_matrix_user: read server url from config
88f7d31 
Fixes #3672:
`https://localhost:8448` is virtually never right.
richvdh added a commit that referenced this issue Aug 25, 2022
@richvdh
register_new_matrix_user: read server url from config (#13616)
a2ce614 
Fixes #3672:
`https://localhost:8448` is virtually never right.
@richvdh richvdh self-assigned this Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@richvdh richvdh

Labels
z-minor (Deprecated Label) z-p2 (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

register_new_matrix_user: read server url from config matrix-org/synapse
3 participants
@neilisfragile @melroy89 @richvdh