Write some tests for the email pusher #4095
Conversation
tests/push/test_email.py
Outdated
| self.pump(100) | ||
|
|
||
| # It then tries to send the email. | ||
| self.assertEqual(len(self.reactor.tcpClients), 1) |
There was a problem hiding this comment.
Can we hook in somewhere to count the number of actual attempts by the email pushers? I feel like this is going to easily break if we add other things that attempt to make tcp requests during handling of events.
|
|
||
| - python: 3.6 | ||
| env: TOX_ENV=py36 | ||
| env: TOX_ENV=py36 TRIAL_FLAGS="-j 2" |
There was a problem hiding this comment.
Why do we use -j 2 here rather than -j 4 like we do for the postgres tests?
There was a problem hiding this comment.
I tested it, -j 2 is faster for SQLite, which has less I/O blocking and therefore is approximate to the speed of your CPU. -j 4 is better for Postgres which has a lot more I/O blocking (mostly creating the database).
There was a problem hiding this comment.
(Possibly a comment to that effect would be useful)
synapse/server.py
Outdated
| return self._sendmail | ||
| else: | ||
| from twisted.mail.smtp import sendmail | ||
| return sendmail |
There was a problem hiding this comment.
Can we move the import up to the top please?
Also, I'd be tempted to instead add sendmail to DEPENDENCIES and define:
def build_sendmail(self):
return sendmailWhich bring it inline with other dependencies. To override in the tests its enough to explicitly define sendmail on the HS object, which can be done by passing sendmail kwarg to setup_test_homeserver
synapse/push/mailer.py
Outdated
|
|
||
| yield sendmail( | ||
| yield self.hs.get_sendmail()( |
There was a problem hiding this comment.
We generally try and pull out dependencies in the constructor, so that things fail at startup if there is a problem with initialising in dependencies
(I thought I made this comment, but GH forgot it :/)
Features -------- - Include flags to optionally add `m.login.terms` to the registration flow when consent tracking is enabled. ([\#4004](#4004), [\#4133](#4133), [\#4142](#4142), [\#4184](#4184)) - Support for replacing rooms with new ones ([\#4091](#4091), [\#4099](#4099), [\#4100](#4100), [\#4101](#4101)) Bugfixes -------- - Fix exceptions when using the email mailer on Python 3. ([\#4095](#4095)) - Fix e2e key backup with more than 9 backup versions ([\#4113](#4113)) - Searches that request profile info now no longer fail with a 500. ([\#4122](#4122)) - fix return code of empty key backups ([\#4123](#4123)) - If the typing stream ID goes backwards (as on a worker when the master restarts), the worker's typing handler will no longer erroneously report rooms containing new typing events. ([\#4127](#4127)) - Fix table lock of device_lists_remote_cache which could freeze the application ([\#4132](#4132)) - Fix exception when using state res v2 algorithm ([\#4135](#4135)) - Generating the user consent URI no longer fails on Python 3. ([\#4140](#4140), [\#4163](#4163)) - Loading URL previews from the DB cache on Postgres will no longer cause Unicode type errors when responding to the request, and URL previews will no longer fail if the remote server returns a Content-Type header with the chartype in quotes. ([\#4157](#4157)) - The hash_password script now works on Python 3. ([\#4161](#4161)) - Fix noop checks when updating device keys, reducing spurious device list update notifications. ([\#4164](#4164)) Deprecations and Removals ------------------------- - The disused and un-specced identicon generator has been removed. ([\#4106](#4106)) - The obsolete and non-functional /pull federation endpoint has been removed. ([\#4118](#4118)) - The deprecated v1 key exchange endpoints have been removed. ([\#4119](#4119)) - Synapse will no longer fetch keys using the fallback deprecated v1 key exchange method and will now always use v2. ([\#4120](#4120)) Internal Changes ---------------- - Fix build of Docker image with docker-compose ([\#3778](#3778)) - Delete unreferenced state groups during history purge ([\#4006](#4006)) - The "Received rdata" log messages on workers is now logged at DEBUG, not INFO. ([\#4108](#4108)) - Reduce replication traffic for device lists ([\#4109](#4109)) - Fix `synapse_replication_tcp_protocol_*_commands` metric label to be full command name, rather than just the first character ([\#4110](#4110)) - Log some bits about room creation ([\#4121](#4121)) - Fix `tox` failure on old systems ([\#4124](#4124)) - Add STATE_V2_TEST room version ([\#4128](#4128)) - Clean up event accesses and tests ([\#4137](#4137)) - The default logging config will now set an explicit log file encoding of UTF-8. ([\#4138](#4138)) - Add helpers functions for getting prev and auth events of an event ([\#4139](#4139)) - Add some tests for the HTTP pusher. ([\#4149](#4149)) - add purge_history.sh and purge_remote_media.sh scripts to contrib/ ([\#4155](#4155)) - HTTP tests have been refactored to contain less boilerplate. ([\#4156](#4156)) - Drop incoming events from federation for unknown rooms ([\#4165](#4165))
No description provided.