This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Do a GC after each test to fix logcontext leaks #4227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feels like an awful hack, but...
richvdh
added this to To Do
in Superceded by https://github.com/orgs/matrix-org/projects/8
via automation
richvdh
moved this from To Do
to Review
in Superceded by https://github.com/orgs/matrix-org/projects/8
Codecov Report
@@ Coverage Diff @@
## develop #4227 +/- ##
==========================================
Coverage ? 66.65%
==========================================
Files ? 299
Lines ? 29796
Branches ? 4871
==========================================
Hits ? 19860
Misses ? 8501
Partials ? 1435Continue to review full report at Codecov.
|
hawkowl
approved these changes
Nov 27, 2018
Superceded by https://github.com/orgs/matrix-org/projects/8
automation
moved this from Review
to Done - Operations
Nov 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces an earlier attempt to fix these leaks on #4213.
This feels like an awful hack, but perhaps it's the least bad option