This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Support for http proxies via http_proxy / HTTPS_PROXY env vars #6238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix some bugs on python 3 * better docstrings * tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for routing outbound HTTP requests via a proxy.
The
http_proxyandHTTPS_PROXYenv vars can be set to ahost[:port]value which should point to a proxy.The address of the proxy should be excluded from IP blacklists such as the
url_preview_ip_range_blacklist.The proxy will then be used for
It will not be used for:
Fixes #4198.