This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Don't assign numeric IDs for empty usernames #6690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug where we would assign a numeric userid if somebody tried registering with an empty username
erikjohnston
approved these changes
Jan 13, 2020
|
Don't we error if people try and do this? Or am I misremembering? |
|
I think it depends which code path you take to get to this point... there are 8 different calls to |
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '2d07c7377': Don't assign numeric IDs for empty usernames (#6690)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where we would assign a numeric userid if somebody tried registering
with an empty username