Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

prometheus_client 0.8.0 not supported #7641

Closed
z3ntu opened this issue Jun 5, 2020 · 3 comments · Fixed by #7780
Closed

prometheus_client 0.8.0 not supported #7641

z3ntu opened this issue Jun 5, 2020 · 3 comments · Fixed by #7780

Comments

@z3ntu
Copy link
Contributor

z3ntu commented Jun 5, 2020

Description

Synapse doesn't with prometheus_client 0.8.0 installed. synapse/python_dependencies.py specifies "prometheus_client>=0.0.18,<0.8.0", so an error is thrown with version 0.8.0.

Steps to reproduce

  • install prometheus_client 0.8.0 from pypi
  • try to start synapse

Version information

  • Version: 1.13.0

  • Install method: Package manager

  • Platform: Arch Linux
@Bubu
Copy link
Contributor

Bubu commented Jun 8, 2020

FWIW after patching out the version check prometheus monitoring still works fine.

The archlinux bug tracking this is here: https://bugs.archlinux.org/index.php?do=details&action=details.addvote&task_id=66901

@z3ntu
Copy link
Contributor Author

z3ntu commented Jun 8, 2020

@Bubu You're linking to the 'addvote' page 😉 Maybe https://bugs.archlinux.org/task/66901 would be a better link. I've also patched out the version requirement from /usr/lib/python3.8/site-packages/synapse/python_dependencies.py and everything seems to work fine, but I don't use prometheus monitoring (as far as I know).

@okurz okurz mentioned this issue Jul 3, 2020
Merged
@richvdh
Copy link
Member

richvdh commented Jul 3, 2020

install prometheus_client 0.8.0 from pypi

I'm tempted to say "don't do that" :-p

okurz added a commit to okurz/synapse that referenced this issue Jul 3, 2020
@okurz
Allow to use higher versions of prometheus_client
9b543b1 
Fixes matrix-org#7641

The package was pinned to <0.8.0 without an obvious reasoning with
7ad1d76
in matrix-org#5636
while the version selection looks to just try to exclude an arbitrary
next minor version number that might introduce API breaking changes.
Selecting the next minor number might be a good conservative selection.

Downstream distributions already reported success patching out the version
requirements.

This also fixes the integration of upgraded packages into openSUSE packages,
e.g. for openSUSE Tumbleweed which already ships prometheus_client >= 0.8 .

Signed-off-by: Oliver Kurz <okurz@suse.de>
richvdh added a commit that referenced this issue Jul 6, 2020
@okurz @richvdh
Allow to use higher versions of prometheus_client (#7780)
4e11874 
Fixes #7641

The package was pinned to <0.8.0 without an obvious reasoning with
7ad1d76
in #5636
while the version selection looks to just try to exclude an arbitrary
next minor version number that might introduce API breaking changes.
Selecting the next minor number might be a good conservative selection.

Downstream distributions already reported success patching out the version
requirements.

This also fixes the integration of upgraded packages into openSUSE packages,
e.g. for openSUSE Tumbleweed which already ships prometheus_client >= 0.8 .

Signed-off-by: Oliver Kurz <okurz@suse.de>

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow to use higher versions of prometheus_client okurz/synapse
3 participants
@Bubu @richvdh @z3ntu