Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix up types and comments that refer to Deferreds. #7945

Merged
merged 3 commits into from
Jul 24, 2020

Conversation

clokep
Copy link
Member

@clokep clokep commented Jul 24, 2020

Some comments refer to functions returning a Deferred which have now been converted to async. This tries to clean those up (and some other type information).

This only touches comments and type hints.

@clokep clokep requested a review from a team July 24, 2020 13:21
synapse/handlers/identity.py Outdated Show resolved Hide resolved
synapse/handlers/identity.py Show resolved Hide resolved
synapse/handlers/identity.py Show resolved Hide resolved
synapse/handlers/identity.py Outdated Show resolved Hide resolved
synapse/handlers/identity.py Show resolved Hide resolved
@clokep clokep requested a review from richvdh July 24, 2020 14:20
@clokep
Copy link
Member Author

clokep commented Jul 24, 2020

Thanks for the review @richvdh! I corrected the missing type hints and re-checked that file to make sure the rest seem sane. I added it to mypy too. 👍

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@clokep clokep merged commit e739b20 into develop Jul 24, 2020
@clokep clokep deleted the clokep/deferred-comments branch July 24, 2020 14:53
anoadragon453 added a commit that referenced this pull request Jul 28, 2020
…rove_test_times

* 'develop' of github.com:matrix-org/synapse: (148 commits)
  Add script for finding files with unix line terminators (#7965)
  Convert the remaining media repo code to async / await. (#7947)
  Convert a synapse.events to async/await. (#7949)
  Convert groups and visibility code to async / await. (#7951)
  Convert push to async/await. (#7948)
  update changelog
  1.18.0rc1
  Fix error reporting when using `opentracing.trace` (#7961)
  Fix typing replication not being handled on master (#7959)
  Remove hacky error handling for inlineDeferreds. (#7950)
  Convert tests/rest/admin/test_room.py to unix file endings (#7953)
  Support oEmbed for media previews. (#7920)
  Convert state resolution to async/await (#7942)
  Fix up types and comments that refer to Deferreds. (#7945)
  Do not convert async functions to Deferreds in the interactive_auth_handler (#7944)
  Convert more of the media code to async/await (#7873)
  Return an empty body for OPTIONS requests. (#7886)
  Downgrade warning on client disconnect to INFO (#7928)
  Convert presence handler helpers to async/await. (#7939)
  Update the auth providers to be async. (#7935)
  ...
@clokep clokep mentioned this pull request Jul 30, 2020
48 tasks
babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit 'f88c48f3b':
  1.18.0rc1
  Fix error reporting when using `opentracing.trace` (#7961)
  Fix typing replication not being handled on master (#7959)
  Remove hacky error handling for inlineDeferreds. (#7950)
  Convert tests/rest/admin/test_room.py to unix file endings (#7953)
  Support oEmbed for media previews. (#7920)
  Convert state resolution to async/await (#7942)
  Fix up types and comments that refer to Deferreds. (#7945)
  Do not convert async functions to Deferreds in the interactive_auth_handler (#7944)
  Convert more of the media code to async/await (#7873)
  Return an empty body for OPTIONS requests. (#7886)
  Downgrade warning on client disconnect to INFO (#7928)
  Convert presence handler helpers to async/await. (#7939)
  Update the auth providers to be async. (#7935)
  Put a cache on `/state_ids` (#7931)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants