Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Only do restricted join rules signature checks for room versions 8/9. #10927

Merged
merged 3 commits into from
Sep 28, 2021
Merged

Only do restricted join rules signature checks for room versions 8/9. #10927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02d36c2
Only do signature checks for room versions 8/9.
clokep Sep 27, 2021
7527dc9
Newsfragment
clokep Sep 27, 2021
dc2d1ea
Lint
clokep Sep 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/10927.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a bug introduced in Synapse v1.40.0 where the signature checks for room version 8/9 could be applied to earlier room versions in some situations.
3 changes: 2 additions & 1 deletion synapse/event_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,8 @@ def check(
raise AuthError(403, "Event not signed by sending server")

is_invite_via_allow_rule = (
event.type == EventTypes.Member
room_version_obj.msc3083_join_rules
and event.type == EventTypes.Member
and event.membership == Membership.JOIN
and "join_authorised_via_users_server" in event.content
)
Expand Down