This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Allow clients to supply access_tokens as headers #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clients can continue to supply access tokens as query parameters or can supply the token as a header: Authorization: Bearer <access_token_goes_here> This matches the ouath2 format of https://tools.ietf.org/html/rfc6750#section-2.1
|
what clients are you expecting to be using this, btw? |
|
LGTM, other than tests. |
None at the moment. I was thinking of hacking up the JS client to use it at somepoint. |
|
I appreciate this expands the scope significantly, but if we're going so far as to move the access token into headers, perhaps it's a good time to consider making the access token into a session key and using it to sign requests (per https://www.ietf.org/archive/id/draft-ietf-oauth-v2-http-mac-05.txt) instead of sending the whole thing back on each request? |
This was referenced Mar 7, 2017
krombel
added a commit
to krombel/synapse
that referenced
this pull request
Jun 16, 2017
…rg#1098 Signed-off-by: Matthias Kesler <krombel@krombel.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clients can continue to supply access tokens as query parameters
or can supply the token as a header:
Authorization: Bearer <access_token_goes_here>
This matches the ouath2 format of
https://tools.ietf.org/html/rfc6750#section-2.1