Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Refactor create_new_client_event to use a new parameter, state_event_ids, which accurately describes the usage with MSC2716 instead of abusing auth_event_ids #12083

Merged
merged 13 commits into from
Mar 25, 2022
Merged

Refactor create_new_client_event to use a new parameter, state_event_ids, which accurately describes the usage with MSC2716 instead of abusing auth_event_ids #12083

merged 13 commits into from
Mar 25, 2022

Commits on Feb 25, 2022

  1. Refactor create_new_client_event to use full state parameter 

    Instead of abusing and re-using auth_event_ids which should only contain state
event ids which are used to auth the given event.

Spawned from #10975 (comment)
    @MadLittleMods
    MadLittleMods committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    93bf1f1 View commit details
    Browse the repository at this point in the history

  2. Better parameter name and docstring description

    @MadLittleMods
    MadLittleMods committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    6a7879f View commit details
    Browse the repository at this point in the history

  3. Clarify which state events are being persisted

    @MadLittleMods
    MadLittleMods committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    f4fde12 View commit details
    Browse the repository at this point in the history

  4. Fix type checking lint 

    ```
synapse/handlers/message.py:964: error: Argument "prev_event_ids" to "build" of "EventBuilder" has incompatible type "Optional[List[str]]"; expected "List[str]"  [arg-type]
```
    @MadLittleMods
    MadLittleMods committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    0942f53 View commit details
    Browse the repository at this point in the history

  5. Add changelog

    @MadLittleMods
    MadLittleMods committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    ffa58ed View commit details
    Browse the repository at this point in the history

  6. Fix changelog grammar

    @MadLittleMods
    MadLittleMods committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    09be642 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2022

  1. Merge branch 'develop' into madlittlemods/10975-r813183430-refactor-t… 

    …o-full-state-parameter

Conflicts:
	scripts-dev/complement.sh
	synapse/handlers/message.py
    @MadLittleMods
    MadLittleMods committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    f3e234e View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2022

  1. Only define state at start of floating chain and derive rest 

    Context: #12083 (comment)
    @MadLittleMods
    MadLittleMods committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    878bdda View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into madlittlemods/10975-r813183430-refactor-t… 

    …o-full-state-parameter
    @MadLittleMods
    MadLittleMods committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    225675b View commit details
    Browse the repository at this point in the history

  3. More comment clarification and fix argument typos

    @MadLittleMods
    MadLittleMods committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    aa0a109 View commit details
    Browse the repository at this point in the history

  4. Explain why we want to set the state there

    @MadLittleMods
    MadLittleMods committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    9f902da View commit details
    Browse the repository at this point in the history

  5. Update comment docs

    @MadLittleMods
    MadLittleMods committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    289faf1 View commit details
    Browse the repository at this point in the history

  6. Some cleanup

    @MadLittleMods
    MadLittleMods committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    cd93056 View commit details
    Browse the repository at this point in the history