Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Disable groups/communities by default. #12344

Merged
merged 1 commit into from
Apr 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/12344.removal
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
The groups/communities feature in Synapse has been disabled by default.
7 changes: 7 additions & 0 deletions docs/upgrade.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,13 @@ process, for example:
dpkg -i matrix-synapse-py3_1.3.0+stretch1_amd64.deb
```

# Upgrading to v1.58.0

## Groups/communities feature has been disabled by default

The non-standard groups/communities feature in Synapse has been disabled by default
and will be removed in Synapse v1.61.0.

# Upgrading to v1.57.0

## Changes to database schema for application services
Expand Down
2 changes: 1 addition & 1 deletion synapse/config/experimental.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def read_config(self, config: JsonDict, **kwargs: Any) -> None:
self.msc3720_enabled: bool = experimental.get("msc3720_enabled", False)

# The deprecated groups feature.
self.groups_enabled: bool = experimental.get("groups_enabled", True)
self.groups_enabled: bool = experimental.get("groups_enabled", False)

# MSC2654: Unread counts
self.msc2654_enabled: bool = experimental.get("msc2654_enabled", False)
1 change: 1 addition & 0 deletions tests/rest/admin/test_admin.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ def prepare(self, reactor: MemoryReactor, clock: Clock, hs: HomeServer) -> None:
self.other_user = self.register_user("user", "pass")
self.other_user_token = self.login("user", "pass")

@unittest.override_config({"experimental_features": {"groups_enabled": True}})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really only have one test that uses groups?

Edit: ah, I see. The flag changes whether or not the servlets get registered; the other tests register the servlets themselves.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only one that fails directly when you disable groups for the reasoning you give, yes! 👍

Note that we did have a bunch of sytests that I removed recently. #11584 has all the cross links!

def test_delete_group(self) -> None:
# Create a new group
channel = self.make_request(
Expand Down